Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client.socket.domain for symmetry with server.socket.domain #255

Closed
trask opened this issue Aug 14, 2023 · 3 comments
Closed

Add client.socket.domain for symmetry with server.socket.domain #255

trask opened this issue Aug 14, 2023 · 3 comments
Assignees

Comments

@trask
Copy link
Member

trask commented Aug 14, 2023

Originally from #206 (comment)

@trask
Copy link
Member Author

trask commented Sep 5, 2023

One idea @lmolkova and I briefly discussed (we're not sure if it's a good idea or not yet) is that since server.socket.domain is very specific to proxy use case, maybe it could be renamed to proxy.address?

@Oberon00
Copy link
Member

Oberon00 commented Sep 6, 2023

It could be a proxy or reverse proxy. How about peer.address? (Only half joking)

@trask
Copy link
Member Author

trask commented Oct 24, 2023

server.socket.domain has been removed now (it was not carried over to the new network.peer/local.*)

the thought is to revisit the use case for server.socket.domain (forward proxies) in the future, potentially with new attribute(s), e.g. proxy.address

so I think this can probably be closed

@trask trask closed this as completed Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants