add remaining url fields to the registry #496
Merged
+122
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
arminru
reviewed
Nov 14, 2023
|
I would like to bump this PR, are there any other questions? |
joaopgrassi
approved these changes
Feb 9, 2024
jsuereth
approved these changes
Feb 12, 2024
|
This particular PR isn't affected by build tools change, so it can be unblocked. If I remember correctly it was blocked due to uncertainty with password/username fields and those are removed now for PR |
ChrsMark
pushed a commit
to ChrsMark/semantic-conventions
that referenced
this pull request
Feb 21, 2024
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds remaining url fields from ECS to the registry
Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.