Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ms-vscode.wasm-wasi-core and ms-vscode.webshell #763

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Add ms-vscode.wasm-wasi-core and ms-vscode.webshell #763

merged 4 commits into from
Jun 21, 2024

Conversation

glebbash
Copy link
Contributor

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR adds ms-vscode.wasm-wasi-core and ms-vscode.webshell extensions.

Request for the author to add: microsoft/vscode-wasm#152, same situation as with vscode-eslint extension: microsoft/vscode-eslint#1842 (comment)
MIT license: https://github.com/microsoft/vscode-wasm/blob/main/LICENSE

@glebbash
Copy link
Contributor Author

P.S: not sure if the version bump in the build script will be a problem

@filiptronicek
Copy link
Collaborator

filiptronicek commented Jun 18, 2024

Hey @glebbash, thanks a lot for the contribution. It looks like with the current configuration tsc is not super happy. Could you take a look?

Happy to merge when it compiles

@glebbash
Copy link
Contributor Author

Not sure what was wrong with the previous setup, locally everything worked fine. Updated to custom package scripts.

@filiptronicek can you pls rerun the workflow?

@filiptronicek
Copy link
Collaborator

Apparently, typescript still won't budge.

I could reproduce this in a Gitpod workspace using this command:

EXTENSIONS=ms-vscode.wasm-wasi-core,ms-vscode.webshell SKIP_PUBLISH=true node publish-extensions

@glebbash
Copy link
Contributor Author

Ok, finally figured it out, needed to do npm i in the root of the repository and not in the packages.

Copy link
Collaborator

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good :shipit:, these should be available on https://open-vsx.org tomorrow on Monday

@filiptronicek filiptronicek merged commit 7308301 into open-vsx:master Jun 21, 2024
1 check passed
@glebbash glebbash deleted the add-vscode-wasm-extensions branch June 21, 2024 15:38
@glebbash
Copy link
Contributor Author

Yo @filiptronicek, any ideas why these extensions were not published?

They are present in the last action report but links to them are 404.

@filiptronicek
Copy link
Collaborator

@glebbash I think it may have something to do with eclipse/openvsx#945, which should land shortly. Let's see if tomorrow's or Wednesday's CI job picks it up.

@glebbash
Copy link
Contributor Author

Yay, there are deployed 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants