-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to lit v2 #36
Conversation
d27e3e3
to
9372e85
Compare
9372e85
to
84a0b87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of tiny nits and a question or two...
src/generators/app-lit-element-ts/templates/static-testing/web-test-runner.config.mjs
Outdated
Show resolved
Hide resolved
src/generators/app-lit-element/templates/static-testing/web-test-runner.config.mjs
Outdated
Show resolved
Hide resolved
src/generators/testing-wtr-ts/templates/static/web-test-runner.config.mjs
Outdated
Show resolved
Hide resolved
src/generators/testing-wtr/templates/static/web-test-runner.config.mjs
Outdated
Show resolved
Hide resolved
src/generators/wc-lit-element-ts/templates/static/web-dev-server.config.mjs
Show resolved
Hide resolved
src/generators/wc-lit-element/templates/static/web-dev-server.config.mjs
Show resolved
Hide resolved
I tried resolving conflicts on my local copy of the branch by taking both changes (and manually resolving duplicate dependencies as later version).
|
Alright I got the tests to run but that raised some questions. This PR, as it is when master is merged in, seems like it's in an odd state. There are multiple references to |
Merges in master renames (now internal) scaffoldFilesFor to _scaffoldFilesFor removes deprecated CLIEngine usage installs devDependencies to match fully loaded project
This PR installs some seemingly useless devDependencies:
and
These are here because our integration testing writes actual files to the |
replaced |
What I did