Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the correctness and documentation of setFunctionVarRefs #964

Open
zapateo opened this issue Dec 13, 2024 · 0 comments
Open

Review the correctness and documentation of setFunctionVarRefs #964

zapateo opened this issue Dec 13, 2024 · 0 comments
Labels
emitter/builder Related to VM's emitter and builder needsInvestigation Need to investigate

Comments

@zapateo
Copy link
Member

zapateo commented Dec 13, 2024

Review the correctness and documentation of:

func (em *emitter) setFunctionVarRefs(fn *runtime.Function, closureVars []ast.Upvar) {

This is because the terminology used within this method appears a bit different from the rest of the code. Is this just a misunderstanding in its interpretation, or does it actually express different concepts or handle things differently than other parts of the code, thus hiding potential errors?

It is therefore necessary to delve into this function well, understand what it is supposed to do and evaluate whether it is necessary to make changes.

@zapateo zapateo added emitter/builder Related to VM's emitter and builder needsInvestigation Need to investigate labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter/builder Related to VM's emitter and builder needsInvestigation Need to investigate
Projects
None yet
Development

No branches or pull requests

1 participant