Passcode activity enhanced with biometric authentication #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upstream sdk version is needed to compile the imported libraries Signed-off-by: aditya-gupta99 <ashishgupta9936ad@gmail.com>
Aditya-gupta99
force-pushed
the
biometric
branch
from
a3e7643
to
cc9fb98
Compare
|
@avinash14022002 Now the PR has been separated, please review it. |
avivijay19
approved these changes
Jun 6, 2023
avivijay19
reviewed
Jun 6, 2023
| @@ -34,6 +35,20 @@ class PassCodeActivity : MifosPassCodeActivity() { | |||
| currPassCode = it.getStringExtra(Constants.CURR_PASSWORD) | |||
| isToUpdatePassCode = it.getBooleanExtra(Constants.IS_TO_UPDATE_PASS_CODE, false) | |||
| } | |||
| if(findViewById<AppCompatButton>(R.id.btn_save).text.equals("Login with biometric")){ | |||
There was a problem hiding this comment.
@Aditya-gupta99 ,
Please use butter knife currently
avivijay19
reviewed
Jun 6, 2023
| BiometricAuthentication(this).authenticateWithBiometrics() | ||
| } | ||
| if(BiometricAuthentication(this).getBiometricCapabilities()==BiometricCapability.HAS_BIOMETRIC_AUTH){ | ||
| val btn=findViewById<AppCompatButton>(R.id.btn_save) |
There was a problem hiding this comment.
butterknife
please use proper naming variable
avivijay19
reviewed
Jun 6, 2023
| } | ||
| } | ||
| } else { | ||
| TODO("VERSION.SDK_INT < P") |
There was a problem hiding this comment.
@Aditya-gupta99
what is expected here?
avivijay19
requested changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1904
demo.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.