Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding plural strings for units #451

Open
olinux opened this issue Sep 25, 2023 · 3 comments
Open

Adding plural strings for units #451

olinux opened this issue Sep 25, 2023 · 3 comments
Labels
major update large workload or major update needed to complete request any request or update for schemas

Comments

@olinux
Copy link
Member

olinux commented Sep 25, 2023

For display purposes, it would be nice to register the plural for a unit in the controlled term (e.g. "years" for "year").

https://github.com/HumanBrainProject/openMINDS_controlledTerms/blob/d8bc03dce7c5764f80e2ced630dde4e572ffbb7b/schemas/unitOfMeasurement.schema.tpl.json#L1

@UlrikeS91
Copy link
Collaborator

I just closed the PR, thinking that this is not required anymore: #61.

In one of the comments, @lzehl was against adding plurals. But maybe worth discussing again?

@UlrikeS91
Copy link
Collaborator

PS: I'm keeping this issue in the controlledTerms-repo for now. This may affect the instances-repo as well, since all UnitOfMeasurement instances would need to be updated. But we can still move it when we see the need for it.

@UlrikeS91 UlrikeS91 added help extra attention is needed question further information is requested request any request or update for schemas labels May 8, 2024
@lzehl
Copy link
Member

lzehl commented May 13, 2024

@olinux @UlrikeS91 @apdavison I suggest we discuss this in our Dev meeting.

I would like to discuss the schema and registration of units in general, because I think they should be a bit more complex than our usual controlled term. I personally do not like that we are currently registering every multiples of a unit (g, kg, mg, ng, etc) and I'm missing explicit information (e.g. unit of what? (mass, time, etc), abbreviation, plurals for fullNames). I also would like to be able to more clearly register SI based units separate from other units.

@lzehl lzehl added major update large workload or major update needed to complete and removed help extra attention is needed question further information is requested labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major update large workload or major update needed to complete request any request or update for schemas
Projects
None yet
Development

No branches or pull requests

3 participants