Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.15: Do not install toml #1217

Closed
ax3l opened this issue Mar 4, 2022 · 4 comments
Closed

0.15: Do not install toml #1217

ax3l opened this issue Mar 4, 2022 · 4 comments
Assignees
Labels
bug install third party third party libraries that are shipped and/or linked

Comments

@ax3l
Copy link
Member

ax3l commented Mar 4, 2022

When doing the default super-build, the toml sub-project should not be installed.
It's a private dependency.

Follow-up to #1148 #1146.

Similar to:

@ax3l ax3l added the bug label Mar 4, 2022
@ax3l ax3l added the install label Mar 4, 2022
@ax3l
Copy link
Member Author

ax3l commented Mar 4, 2022

X-ref: ToruNiina/toml11#185

@franzpoeschel
Copy link
Contributor

X-ref: ToruNiina/toml11#185

Should I close https://github.com/openPMD/openPMD-api/pull/1210/files then and we go with your solution as soon as it's merged?

@ax3l
Copy link
Member Author

ax3l commented Mar 6, 2022

We can keep that PR open in case toml11 merges our PR too slowly (aka before we want to cut 0.15.0).

@ax3l ax3l mentioned this issue Mar 14, 2022
@ax3l
Copy link
Member Author

ax3l commented Mar 14, 2022

Fixed via #1227

@ax3l ax3l closed this as completed Mar 14, 2022
@ax3l ax3l added the third party third party libraries that are shipped and/or linked label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug install third party third party libraries that are shipped and/or linked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants