Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(azure): example for custom base URL #1055

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

AngelosP
Copy link
Contributor

  • [ X ] I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Improved the comment for AzureOpenAI's baseURL constructor parameter to offer an example. It's not easy to deduce that the /openai/ part should be included, so I think it's helpful to have an example that points that out and it's consistent with the comments of other constructor parameters.

@AngelosP AngelosP requested a review from a team as a code owner September 10, 2024 22:46
@RobertCraigie RobertCraigie changed the base branch from master to next September 11, 2024 10:08
@RobertCraigie RobertCraigie changed the title Improved comment for AzureOpenAI's baseURL docs(azure): example for custom base URL Sep 11, 2024
Copy link
Collaborator

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobertCraigie RobertCraigie merged commit 20defc8 into openai:next Sep 11, 2024
3 checks passed
@stainless-app stainless-app bot mentioned this pull request Sep 11, 2024
stainless-app bot pushed a commit that referenced this pull request Sep 11, 2024
Co-authored-by: Angelos Petropoulos <angelpe@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants