feat(azure): support for the Realtime API #1963
Merged
+65
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertCraigie
changed the title
RobertCraigie
approved these changes
Dec 19, 2024
src/openai/_utils/_utils.py
Outdated
| return isinstance(client, AsyncAzureOpenAI) | ||
|
|
||
|
|
||
| def configure_azure_realtime(client: AzureOpenAI, model: str, extra_query: Query) -> tuple[Query, dict[str, str]]: |
There was a problem hiding this comment.
nit: is the reason the configure_azure_realtime and configure_azure_realtime_async functions are in _utils.py because of circular imports?
I think it'd be cleaner to define these as private methods on the client classes themselves, then the __aenter__ method changes are just
if is_async_azure_client(self.__client):
extra_query, auth_headers = await self.__client._configure_realtime(self.__model, extra_query)There was a problem hiding this comment.
Good call, that's a lot cleaner. Updated!
|
Would probably be a good idea to add an Azure specific example script as well? |
Merged
Sorry I just saw this. Added a simple example here: #1967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Ensure we configure the websocket connection with the right configuration for Azure.
Additional context & links