-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: transcribe verbosity #140
fix: transcribe verbosity #140
Conversation
I actually intended the two to be displayed even when |
@jongwook well, ETA is disabled when |
The language tag is returned in the result, but for those calling Regarding ETA: that's true; it's not the most intuitively named options but I thought both formats have merits (like below) and thought it'd be nice to have these verbose/concise output options, but probably better not mix up those two. We can maybe make it an integer level for verbosity if a totally silent output is desired by many .. |
@jongwook
|
I'd like to avoid magic string if possible. It's a bit unorthodox but I'm inclined to making it an I can make these edits on this PR if you'd like/don't mind. |
Don't bother yourself, I have nothing to do at the moment |
whisper/transcribe.py
Outdated
@@ -170,7 +172,7 @@ def add_segment( | |||
num_frames = mel.shape[-1] | |||
previous_seek_value = seek | |||
|
|||
with tqdm.tqdm(total=num_frames, unit='frames', disable=verbose) as pbar: | |||
with tqdm.tqdm(total=num_frames, unit='frames', disable=verbose is False) as pbar: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this verbose is not False
? Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I've hidden "Detected langauge: " massage behind
verbose
flag.Also fixed the flag usage with tqdm