Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer crashes when sideloading progress goes over 100% #380

Closed
SirRGB opened this issue Dec 2, 2023 · 3 comments · Fixed by #400
Closed

Installer crashes when sideloading progress goes over 100% #380

SirRGB opened this issue Dec 2, 2023 · 3 comments · Fixed by #400
Assignees
Labels
bug Something isn't working

Comments

@SirRGB
Copy link
Contributor

SirRGB commented Dec 2, 2023

Describe the bug
When flashing Magisk the installer gets stuck.
Device seems to reboot into recovery.

To Reproduce
Steps to reproduce the behavior:
Install Magisk-v26.4.zip (renamed from apk) as addon.

Expected behavior
Flashing succeeds and you can continue.
Im fine with a disclaimer too since Magisk is not meant for the target audience of oai.

Log file
https://haste.aicp-rom.com/ujemuyewoq.sql

Screenshots
image

Desktop (please complete the following information):

  • OS: Tuxedo OS 2, i.e. Kubuntu 22.04 LTS

Smartphone (please complete the following information):

  • Device: OnePlus 5
  • OS: crDroid 9.11
  • OAI Version 0.51

Additional context
image
Manually sideloading causes >100% progress, which crashes the progress bar in oai.

@SirRGB SirRGB added the bug Something isn't working label Dec 2, 2023
@anon1892
Copy link
Member

anon1892 commented Dec 2, 2023

It may be related to #256, because it was working when I tested my PR (#222 for example)
However, adb's status progress was above 100%, so was OAI status bar too, but Magisk was installed correctly.

@tsterbak
Copy link
Member

It may be related to #256, because it was working when I tested my PR (#222 for example)

Yeah, I guess the issue with the progressbar was introduced here... I will fix it with the next release.

Install Magisk-v26.4.zip (renamed from apk) as addon.

Maybe we should also allow for apk sideloading? Do you see any downsides there?

@tsterbak tsterbak changed the title Magisk flashing unsupported Installer crashes when sideloading progress goes over 100% Dec 10, 2023
@tsterbak tsterbak self-assigned this Dec 10, 2023
@SirRGB
Copy link
Contributor Author

SirRGB commented Dec 27, 2023

I was able to flash the Magisk apk successfully using the dev branch, so consider this fixed.
Im not quite sure if we should allow apk sideloading in general since the Magisk apk is basically the only apk, that behaves like a zip as far as I know. Maybe allow .zip and Magisk.apk? Sideloading an unsupported apk just throws an error in the recovery...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants