custom recoveries

[SirRGB]

While most devices support twrp it isnt the case for all lineage supported devices. Id suggest adding support for at least the lineage recoveries if thats possible.
edit:
I foolishly just tested it renaming the lineage recoveryimage and saw that you are using some twrp specific commands, so that cant work obv. When installing ota updates there it sometimes says "executing openrecovery script" so that might be helpful... In addition a lot of twrp based custom recoveries exist, which probably still contain these functions, but I have to test that myself ig.

[tsterbak]

In the beginning the tool also supported the LOS recovery, but (as far as I know) it doesn't allow for any scripting so not too much automation is possible. So for now, only TWRP-based recoveries are supported. For example OrangeFox also works in general. But for the average user, I would recommend using a TWRP recovery.
Maybe there will be an advanced guide what else you can do with the tool.

Do you have an example (or examples) of LOS supported devices with no TWRP support?

I will look into the openrecovery script possibilities and maybe there is an option to use the LOS recovery still.

[SirRGB]

Well it isnt supported by your installer, but thr TP1803/Nubia Mini 5G does have official lineage support without twrp. Unofficial builds exist, but dont work on the bootloader that is shipped with the builds.

[SirRGB]

You should update the twrp links for cheeseburger/dumpling as well. It points to the old twrp link, but OP5/T actually got a unified more up to date version...
https://dl.twrp.me/cheeseburger_dumpling/

[tsterbak]

Currently, the link is generated from the device code like this: https://dl.twrp.me/<device-code>.
I will provide options in the config file to pass a custom TWRP link (or even recovery link).

[tsterbak]

Closed with #68

[SirRGB]

Well it isnt supported by your installer, but thr TP1803/Nubia Mini 5G does have official lineage support without twrp. Unofficial builds exist, but dont work on the bootloader that is shipped with the builds.

Xperia 1 II and 5 II dont support official twrp either, but Idk if you should add unofficial twrp support (and Idk if I will bringup these 2)

[tsterbak]

Hm, I would not link to unofficial TWRP sources, since I don't know how stable and trustworthy they are. So I would not recommend them easily. But it's great to support these if people can find them somewhere.
So having no link to a twrp release is not an issue to me. What do you think?

[SirRGB]

Well there is no device supported that doesnt have official twrp for now, so that isnt an issue right now, but supporting these is pretty difficult if you dont support either the lineage recovery nor unofficial ones. In the end it is only booted temporarily from what I saw and only usb and mounting has to work properly (encryption doesnt have to work).
Id prefer having lineage recovery support, but as I said Idk how/if that is possible without user input.

[tsterbak]

I'm not sure if I understand correctly. But unofficial TWRP versions are supported if you can download them somewhere, you can use them. Same as for ROMs.
The lineageOS recovery doesn't support that kind of scripting as far as I could tell so far, so the automation would be limited. Maybe we can find someone who knows more about lineageOS recoveries?

[SirRGB]

oh, nvm Im stupid

[SirRGB]

But still the TP1803 issue persists (not supported yet). https://wiki.lineageos.org/devices/TP1803/install
The official lineage uses the abl v3 bootloader, which cant boot twrp. The v2 one does tho. You could (considering you could somehow automate that edl stuff to unlock the bootloader initially) flash abl v2, boot twrp and then get abl v3 up again. Im not sure if all cables support edl tho and I never had to do this process myself, since it shipped with an unlocked bootloader to me. It is a special device with very few devices in the wild, so it isnt really interesting to maintain tho.

[tsterbak]

I got info from a LineageOS core-developer, that the LineageOS recovery should also have quite some scripting capabilities. So I will explore that and then there might be a way to implement support for the LineageOS recovery and even have a full end to end experience (including downloads) if your device is officially supported by LOS.

[MagicLike]

this should get fixed with #188 (?)

[tsterbak]

this should get fixed with #188 (?)

I guess we are moving forward here, but it's not a full fix yet, since there are still devices where only the LineageOS recovery would provide full (at least official) support.

[anon1892]

For LineageOS recovery, maybe we should focus on only one issue, so maybe #210 ?

[tsterbak]

@SirRGB @anon1892 I will try to tackle this over the holidays and see if I can get OFox and even the LOS recovery in.