-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for displaying specific text about a requirement #80
Comments
Hey @Blue-Sauce, first of all thank you for your interest in the project :) Your suggestion seems like a good idea! There is currently the option to specify additional requirements in the config metadata (https://github.com/openandroidinstaller-dev/openandroidinstaller#how-to-write-metadata). Users will then be asked to check them off before they can continue. |
Before opening the issue I did take a look at how it looks, how the current additional requirements appear in OpenAndroidInstaller. Used my OnePlus Nord N200 (but did I did not complete the install, as I already have lineage on it). That's what prompted me make the suggestion. With the current wording I worry that some users might think it's ok to just try it, or think they probably meet the requirements. Not understand the consequences and the need to be absolutely sure. On xda forums and on telegram several OnePlus Nord N200 users have missed the warnings in the xda guides and got bricked. This is what I currently see for the android 11 requirement |
I see 🤔 |
Could be fixed with #221 |
@Blue-Sauce would you consider this resolved? |
Looking at the screenshot here #114 (comment) it seems good. Though, I would feel better about it if an optional checkbox could be created for devices where it's known that a brick will occur if the user fails to heed the warning. So you could specify a checkbox with text such as this, "I understand that if my device is on android 12, flashing will result in a brick / unusable device." |
I don't think it's very useful : is user does not read, he will neither read what's written next to the checkbox and will check it anyway... |
When one starts automating functions and making things point & click easy, as OAI aims to do, users start to think that it should be smart enough to detect issues that would destroy a device. And they can click without thinking properly. But of course, OAI is unable to detect fatal issues. So I feel it's reasonable to try to prevent damage as much as possible. I think checkbox can help a lot with that. It pulls attention to the warning. As it is, there is only the large "Pick OS Image" button to pull one's attention. |
Some devices have requirements that if not met will result in a failed flash and brick. Could be a soft brick but still something you want to try hard to prevent.
An example is the OnePlus Nord N200. Attempting to flash a custom rom while your device is on android 12 will result in a soft brick. I suggest adding the ability to display specific text about requirements and an optional field in the device config file to specify the message to display about the requirement. I'd also suggest a "brick risk" flag for cases where failing to meet the requirement is known for certain to result in a brick that is difficult or even impossible to recover from. In that case a large danger icon could be displayed to help communicate the danger to the user.
The text was updated successfully, but these errors were encountered: