Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory_reset_sub_menu and test_host_console_sub_menu.robot #2238

Open
justin0309 opened this issue Jan 9, 2024 · 1 comment
Open

Factory_reset_sub_menu and test_host_console_sub_menu.robot #2238

justin0309 opened this issue Jan 9, 2024 · 1 comment

Comments

@justin0309
Copy link

justin0309 commented Jan 9, 2024

@gkeishin
Are these two modifications due to the need to move the code content later? Or are there other purposes?
Or is it that we can modify the position where he wants to appear at will?
Because these two tests correspond to each other, the code of webui-vue is still original. According to the old test, it can pass, but after changes, it fails.

0c1a348

7017895

@gkeishin
Copy link
Member

It was failing in our environment so we fixed it up. Having said that, we didn't get any feedback on GUI earlier, so we merged it.

Good that you are providing feedback that gives us now the view on how to drive Web UI related changes testing better.

@justin0309 let us know if you want us to revert the changes.

FYI @rramyasr @rahulmah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants