Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): linted code of conduct and contribution page #747

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

shinybrar
Copy link
Collaborator

  • very small changes, to get all the green checkmarks :D

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.61%. Comparing base (19f2608) to head (db59e63).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #747   +/-   ##
=========================================
  Coverage     18.61%   18.61%           
  Complexity      102      102           
=========================================
  Files            22       22           
  Lines          1961     1961           
  Branches        270      270           
=========================================
  Hits            365      365           
  Misses         1544     1544           
  Partials         52       52           
Flag Coverage Δ
skaha-unittests-coverage 18.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… broken due to security reason when opening a pr from a fork

the commit msg check will still happen
Copy link
Member

@at88mph at88mph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a blurb about Spotless and Palantir? Even just adding a link to the documentation and that it's specified for the Science Platform and Science Portal.

@shinybrar
Copy link
Collaborator Author

Absolutely, I will add the documentation.

@at88mph at88mph merged commit d7f2eb8 into opencadc:main Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants