From cb4d64a5ab609346d7adf53b63f12ef48345d78e Mon Sep 17 00:00:00 2001
From: Sam Betts <116557335+sambetts-cisco@users.noreply.github.com>
Date: Wed, 28 Jun 2023 12:51:09 +0100
Subject: [PATCH] Fix summaries in the asset table and asset details (#437)

Ensures the data is pulled from the API for the summaries to be
displayed in the assets table.

Ensures that assets with missing summary data don't crash the UI when in
the assets drill down, without this change it just displays a blank
screen.
---
 ui/src/layout/Assets/AssetsTable.js             | 2 +-
 ui/src/layout/detail-displays/Findings/index.js | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/ui/src/layout/Assets/AssetsTable.js b/ui/src/layout/Assets/AssetsTable.js
index d9eb0c628..1b6dd488c 100644
--- a/ui/src/layout/Assets/AssetsTable.js
+++ b/ui/src/layout/Assets/AssetsTable.js
@@ -51,7 +51,7 @@ const AssetsTable = () => {
         <TablePage
             columns={columns}
             url={APIS.ASSETS}
-            select="id,targetInfo"
+            select="id,targetInfo,summary"
             tableTitle={TABLE_TITLE}
             filterType={FILTER_TYPES.ASSETS}
             filtersConfig={[
diff --git a/ui/src/layout/detail-displays/Findings/index.js b/ui/src/layout/detail-displays/Findings/index.js
index aa387d703..8a92b84cb 100644
--- a/ui/src/layout/detail-displays/Findings/index.js
+++ b/ui/src/layout/detail-displays/Findings/index.js
@@ -11,7 +11,8 @@ import FindingsCounterDisplay from './FindingsCounterDisplay';
 import FindingsSystemFilterLinks from './FindingsSystemFilterLinks';
 
 const Findings = ({findingsSummary, findingsFilter, findingsFilterTitle, findingsFilterSuffix=""}) => {
-    const {totalVulnerabilities} = findingsSummary || {};
+    findingsSummary = findingsSummary || {};
+    const {totalVulnerabilities} = findingsSummary;
 
     const {pathname} = useLocation();
     const filtersDispatch = useFilterDispatch();
@@ -26,7 +27,7 @@ const Findings = ({findingsSummary, findingsFilter, findingsFilterTitle, finding
                 backPath: pathname,
                 customDisplay: () => (
                     <FindingsSystemFilterLinks
-                        findingsSummary={findingsSummary || {}}
+                        findingsSummary={findingsSummary}
                         totalVulnerabilitiesCount={getTotlalVulnerabilitiesFromCounters(totalVulnerabilities)}
                     />
                 )
@@ -66,4 +67,4 @@ const Findings = ({findingsSummary, findingsFilter, findingsFilterTitle, finding
     )
 }
 
-export default Findings;
\ No newline at end of file
+export default Findings;