You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That context ends when the beforeSuit function runs to completion and after that the context is not available, but with the current solution we want to use that context in actual tests (because we want to have an open SSH connection to VMClarity control plane while the tests are running).
This is not going to work, we have to rework how we pass context from ginkgo's test suite creation to the actual test environments, but I think that's out of the scope of this PR.
The issue why we can't use the
ctx
variable here from theafterSetup
function's parameter is because if you follow up the call chain then thatctx
is thesetupCtx
variable in thebeforeSuit
function, see here: https://github.com/openclarity/vmclarity/blob/main/e2e/suite_test.go#L68That context ends when the
beforeSuit
function runs to completion and after that the context is not available, but with the current solution we want to use that context in actual tests (because we want to have an open SSH connection to VMClarity control plane while the tests are running).This is not going to work, we have to rework how we pass context from ginkgo's test suite creation to the actual test environments, but I think that's out of the scope of this PR.
The situation is the same here in your previous comment - https://github.com/openclarity/vmclarity/pull/1601/files/de050880ac466a03a92bbf25a6497d4bde060beb#diff-7be911ff144b8813d4374c3f85695689dd505e9ace576d90e7f0f2b7a071b421R327 - the context that we pass to the
iamService
is cancelled when thebeforeSuit
ends, but we want to use this context in theTearDown
where we want to undelete the 2 roles.Originally posted by @adamtagscherer in openclarity/vmclarity#1601 (comment)
The text was updated successfully, but these errors were encountered: