Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testenv readiness checks #673

Open
2 tasks done
ramizpolic opened this issue May 21, 2024 · 0 comments
Open
2 tasks done

Fix testenv readiness checks #673

ramizpolic opened this issue May 21, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ramizpolic
Copy link
Member

Description

The readiness check for services can report ready behaviour even when all the services are not ready.

Expected Behavior

Ready returns true iff all services are ready.

Actual Behavior

Ready can be true when last service is ready, unrelated to the state of the previous service.

Steps to Reproduce

https://github.com/openclarity/vmclarity/blob/c688a55d976a7484339f648afd8fdde7a9c5cd2f/testenv/kubernetes/kubernetes.go#L71-L94

Checklist
@ramizpolic ramizpolic added the bug Something isn't working label May 21, 2024
@paralta paralta added the good first issue Good for newcomers label Jun 18, 2024
@ramizpolic ramizpolic transferred this issue from openclarity/vmclarity Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramizpolic @paralta