Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deletion risk in pytests #190

Open
dfulu opened this issue May 31, 2023 · 0 comments · May be fixed by #191
Open

Deletion risk in pytests #190

dfulu opened this issue May 31, 2023 · 0 comments · May be fixed by #191

Comments

@dfulu
Copy link
Member

dfulu commented May 31, 2023

These tests use the DB_URL[_PV] environmental variables we use in multiple places. If these variables are set when these tests are run there is risk of deleting the database. I already did this to the development database.

https://github.com/openclimatefix/nowcasting_datamodel/blob/2d2d836f9705cce37e53ef40d4c0673df453fe2f/tests/conftest.py#LL53C1-L62C26

https://github.com/openclimatefix/nowcasting_datamodel/blob/2d2d836f9705cce37e53ef40d4c0673df453fe2f/tests/conftest.py#LL81C1-L90C49
@devsjc devsjc linked a pull request May 31, 2023 that will close this issue
Remove ability to use non-sqlite db in tests #191
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ability to use non-sqlite db in tests openclimatefix/nowcasting_datamodel
1 participant
@dfulu