Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release version #91

Open
corburn opened this issue Aug 25, 2023 · 5 comments
Open

New release version #91

corburn opened this issue Aug 25, 2023 · 5 comments

Comments

@corburn
Copy link

corburn commented Aug 25, 2023

It's been a few years since the 1.0.0 release with many changes since. Is it possible to cut a stable release? I like the addition of the the Digester interface.

@AkihiroSuda
Copy link
Member

SGTM, cc @opencontainers/go-digest-maintainers PTAL

@thaJeztah
Copy link
Member

overall SGTM; there's one thing I was wondering the other day; when I made my PR (some time ago) to register the default algorithms automatically, that also included sha384 (as it "came with the package"), however the OCI spec doesn't list it (I think; on my phone right now), so I wonder if we should register it by default, or somehow make it optional;

RegisterAlgorithm(SHA384, crypto.SHA384)

@thaJeztah
Copy link
Member

(basically; it's easier to add these things, than to remove, once released)

@corburn
Copy link
Author

corburn commented Jan 4, 2024

@thaJeztah agreed a future release could add registering SHA384 by default.

@thaJeztah
Copy link
Member

Hm, ok, so I had my wires crossed, and thought that before 084376b, the SHA-384 was not registered, but it already was (but could not be used by default, unless "crypto/sha512" was imported.

So removing SHA384 would be a breaking change (and require a major version bump (V2); #97 (comment)

I did open a PR to somewhat improve docs (recommended use / not use);

And perhaps we should indeed consider to remove the "not recommended" algorithms from the default for a V2.0 (don't register SHA-512 and SHA-384 by default, and don't import "crypto/sha512")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants