Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds external costs page, reorganizes for longevity #43

Merged

Conversation

wolfeaustin
Copy link
Contributor

@wolfeaustin wolfeaustin commented Oct 17, 2024

What does this PR change?

  • Adds a new page to handle External Costs
Screenshot 2024-10-17 at 12 48 46 PM

Does this PR relate to any other PRs?

  • N/A

How will this PR impact users?

  • Users will now have the ability to view External Costs

Does this PR address any GitHub or Zendesk issues?

  • Closes ...

How was this PR tested?

  • Locally

Does this PR require changes to documentation?

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 3:52pm

@ameijer
Copy link

ameijer commented Oct 18, 2024

as per our OC community meeting yesterday, @lmello has offered to try this UI out! Will hold merge to that. Thank you Leo!

@ameijer
Copy link

ameijer commented Oct 18, 2024

closes #29

@cliffcolvin
Copy link
Member

@lmello any idea if you'll have any time to look at this one? I'm working to plan a release for kubecon and would love to have this in so we can cut one mid week maybe?

@cliffcolvin cliffcolvin merged commit 459ddc5 into opencost:main Nov 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants