Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on the digitalearthau package #472

Closed
omad opened this issue Nov 9, 2022 · 2 comments
Closed

Remove dependency on the digitalearthau package #472

omad opened this issue Nov 9, 2022 · 2 comments
Labels
cleanup tests

Comments

@omad
Copy link
Member

omad commented Nov 9, 2022

We currently depend on the digitalearthau package for running the test suite. This package is not publicly available from PyPI or conda-forge, and contains lots of code that is no longer actively used. Also, this test fixture code is not compatible with datacube-core >= 1.8.8 (See #453).
We need to remove this dependency.

The test functions are useful for setting up and cleaning up an ODC database.

The easiest solution is probably to copy that code into this repository.

The best solution would be to move that code into datacube-core and have it provide test fixtures for ODC databases.

@jeremyh @Ariana-B @SpacemanPaul @pindge
@pindge
Copy link
Collaborator

pindge commented Nov 9, 2022 •
edited
Loading

related to :
#375
and
opendatacube/datacube-core#1274

@omad omad mentioned this issue Nov 21, 2022
Closed
@omad
Copy link
Member Author

omad commented Dec 20, 2022

Fixed in #490

@omad omad closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omad @pindge