[pull] main from vllm-project:main #8
Conversation
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Co-authored-by: Simon Mo <simon.mo@hey.com>
|
Hi @pull[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…les (#4343) Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Co-authored-by: Antoni Baum <antoni.baum@protonmail.com>
Co-authored-by: DefTruth <31974251+deftruth@users.noreply.github.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com> Co-authored-by: Travis Johnson <tjohnson31415@gmail.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-neuralmagic@users.noreply.github.com> Co-authored-by: Robert Shaw <rshaw@neuralmagic.com>
Co-authored-by: alexm <alexm@neuralmagic.com> Co-authored-by: mgoin <michael@neuralmagic.com>
|
/lgtm |
|
/approve |
|
@pull[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pr-image-mirror |
Head branch was pushed to by a user without write access
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pull[bot], z103cb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR refactors the request validation to explicitly enumerate the errors and messages that TGIS currently implements. It implements most of the missing validation, excluding `PromptPrefix` and `Tokenizer` at the moment, since soft prompts are not supported yet and I'm not 100% sure how exactly to wire up the tokenizer one without running this and figuring out how to trigger it. I'd like to add some basic unit tests here and get a GHA workflow going to run them. (The big blocker to that in general here is the need for GPUs, but I think we can test this logic without needing to load a real model) --------- Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )