Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document of SAC default config need to be updated #601

Closed
4 of 10 tasks
Tracked by #548
Seraphli opened this issue Mar 4, 2023 · 7 comments
Closed
4 of 10 tasks
Tracked by #548

Document of SAC default config need to be updated #601

Seraphli opened this issue Mar 4, 2023 · 7 comments
Labels
doc Documentation

Comments

@Seraphli
Copy link

Seraphli commented Mar 4, 2023

  • I have marked all applicable categories:
    • exception-raising bug
    • RL algorithm bug
    • system worker bug
    • system utils bug
    • code design/refactor
    • documentation request
    • new feature request
  • I have visited the readme and doc
  • I have searched through the issue tracker and pr tracker

It seems the default config document is copied from td3.

@PaParaZz1
Copy link
Member

PaParaZz1 commented Mar 5, 2023

Thanks for your feedback, we will update this doc in 2~3 days.

@PaParaZz1 PaParaZz1 added the doc Documentation label Mar 5, 2023
@PaParaZz1
Copy link
Member

We have updated related comments and doc in this commit (67032d7).

@Seraphli
Copy link
Author

Seraphli commented Mar 7, 2023

Reporting another issue, NGU seems only to have the Chinese version document.
https://di-engine-docs.readthedocs.io/en/latest/12_policies/ngu_zh.html#id5
And is there any plan to provide baseline figures for NGU?

@PaParaZz1
Copy link
Member

We are preparing the contributiors calling plan about algorithm zoo and related docs, are you willing to add an English version doc of NGU? We will provide the corresponding support.

For the baseline figures for NGU, you can refer to #40.

@Seraphli
Copy link
Author

Thanks for the baseline figures. I would like to contribute, but currently, I don't have much time. Maybe later.

@PaParaZz1
Copy link
Member

OK, we will close this issue first. If you have the spare time to contribute related doc, you can raise a pull request in DI-engine-docs and let me know.

@Seraphli
Copy link
Author

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

No branches or pull requests

2 participants