Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Hidden Size List for ContinuousQAC? #826

Closed
Tracked by #548
MarkHolmstrom opened this issue Aug 29, 2024 · 1 comment
Closed
Tracked by #548

No Hidden Size List for ContinuousQAC? #826

MarkHolmstrom opened this issue Aug 29, 2024 · 1 comment
Labels
algo Add new algorithm or improve old one discussion Discussion of a typical issue

Comments

@MarkHolmstrom
Copy link
Contributor

Hello,

I am replicating a TD3 implementation in DI-engine and noticed the actor and critic hidden sizes are forced to be integers for vector observations. Is there a reason for not allowing the MLP to have heterogeneous hidden layer sizes?

@PaParaZz1 PaParaZz1 added discussion Discussion of a typical issue algo Add new algorithm or improve old one labels Aug 30, 2024
@PaParaZz1
Copy link
Member

In our experiments for TD3, we mainly test its performance on the classical MuJoCo environments. For this case, the simple design is suitable and enough to acquire excellent performance. And it often needs more complicated normalization and network initialization techniques when using more complex network. Therefore, we use current design for ContinuousQAC.

If you have other demands for your environment, you can imitate ContinuousQAC class and implement your own QAC network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algo Add new algorithm or improve old one discussion Discussion of a typical issue
Projects
None yet
Development

No branches or pull requests

2 participants