-
Notifications
You must be signed in to change notification settings - Fork 31
Fix csv parsing function #367
Fix csv parsing function #367
Conversation
Signed-off-by: Joshua Li <joshuali925@gmail.com>
This reverts commit 6b3d88f.
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Can we add test case for this? |
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Why CI is not triggered for this PR |
Added. Did we have memory issues with csv reports? I had to flatten the hits to take care of selecting columns like |
https://github.com/joshuali925/kibana-reports/actions check CI here, i think github is having problem with PR triggers |
maybe, like this issue described. opensearch-project/reporting#34 |
Got it. I don't think the issue can be resolved by just optimize memory usage while generating csv. We'll have to introduce some kind of external storage for processing data. So this PR shouldn't affect that issue |
I think a hard limit on csv file size may be another approach, such as 10 MB |
can we merge this in? @joshuali925 |
missing an approval, @davidcui-amzn could you take a look please? |
* Fix csv parsing function, switch json to csv library Signed-off-by: Joshua Li <joshuali925@gmail.com> * Revert "Fix csv parsing function, switch json to csv library" This reverts commit 6b3d88f. * Fix csv parsing function Signed-off-by: Joshua Li <joshuali925@gmail.com> * Flatten nested results for csv * Add test case for nested fields Signed-off-by: Joshua Li <joshuali925@gmail.com> * Use test data from sample_data_ecommerce * Format code
* Fix csv parsing function, switch json to csv library Signed-off-by: Joshua Li <joshuali925@gmail.com> * Revert "Fix csv parsing function, switch json to csv library" This reverts commit 6b3d88f. * Fix csv parsing function Signed-off-by: Joshua Li <joshuali925@gmail.com> * Flatten nested results for csv * Add test case for nested fields Signed-off-by: Joshua Li <joshuali925@gmail.com> * Use test data from sample_data_ecommerce * Format code
Signed-off-by: Joshua Li joshuali925@gmail.com
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.