Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Update the AD Kibana plugin workflows #480

Closed
ohltyler opened this issue Nov 19, 2020 · 2 comments
Closed

Update the AD Kibana plugin workflows #480

ohltyler opened this issue Nov 19, 2020 · 2 comments
Assignees
Labels
infra Infra Team Issues

Comments

@ohltyler
Copy link

ohltyler commented Nov 19, 2020

Change 1 (NOTE: this issue applies to all Kibana plugins using cypress for their integration tests)

Since GitHub actions has deprecated the use of set-env, the old version of the Cypress action (cypress-io/github-action@v1) breaks the workflows.

All calls to this old action need to be updated to any version >= 2.3.1. For example, the issue will be fixed if using the current latest version:

uses: cypress-io/github-action@v2.5.0

Change 2
Since it is necessary to change the built zips to a new naming convention using camelcase, all references to the zip files and unzipped plugin names will need to be changed. For AD Kibana, the following changes will need to be made:

Zip references:
opendistro-anomaly-detection-kibana-$plugin_version.zip -> opendistroAnomalyDetectionKibana-$plugin_version.zip

AD plugin references:
opendistro-anomaly-detection-kibana -> opendistroAnomalyDetectionKibana

Thanks!

@ohltyler ohltyler added question Further information is requested infra Infra Team Issues and removed question Further information is requested labels Nov 19, 2020
@ohltyler ohltyler changed the title Update the AD Kibana plugin workflows to use updated Cypress github action Update the AD Kibana plugin workflows Nov 19, 2020
@gaiksaya
Copy link
Member

gaiksaya commented Nov 19, 2020

Addressed Change 1 in this PR #482

Change 2 is being taken care of by @peterzhuamazon

@peterzhuamazon
Copy link
Contributor

As we discussed change 2 is finalized with Kibana Plugin Owners.

All kibana plugins will change their names to camel cases, so ./bin/kibana-plugin install would work in 7.10.0.
New naming convention format:
opendistro<CamelCasePluginNames>Kibana-<4Digit Plugin Version>.zip

Kibana Naming Convention:
------
opendistroAlertingKibana-1.12.0.x.zip
opendistroAnomalyDetectionKibana-1.12.0.x.zip
opendistroGanttChartKibana-1.12.0.x.zip
opendistroIndexManagementKibana-1.12.0.x.zip
opendistroNoteboooksKibana-1.12.0.x.zip
opendistroQueryWorkbenchKibana-1.12.0.x.zip
opendistroReportsKibana-1.12.0.x.zip
opendistroSecurityKibana-1.12.0.x.zip
opendistroTraceAnalyticsKibana-1.12.0.x.zip

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
infra Infra Team Issues
Projects
None yet
Development

No branches or pull requests

3 participants