We use the Developer Certificate of Origin (DCO) as an additional safeguard for the OpenEBS projects. This is a well established and widely used mechanism to assure that contributors have confirmed their right to license their contribution under the project's license. Please read dcofile. If you can certify it, then just add a line to every git commit message:
Signed-off-by: Random J Developer <random@developer.example.org>
Use your real name (sorry, no pseudonyms or anonymous contributions). The email id should match the email id provided in your GitHub profile.
If you set your user.name
and user.email
in git config, you can sign your commit automatically with git commit -s
.
This project recommends the guidelines mentioned here:
- Go Code Review Comments and
- Formatting and style section of Peter Bourgon's Go: Best Practices for Production Environments.
make lint
If PR is about adding a new feature or bug fixes then Authors of the PR are expected to add a changelog file with their pull request. This changelog file should be a new file created under changelogs/unreleased
folder. Name of this file must be in in pr_number-username
format and contents of the file should be the one liner text which explain the feature or bug fix.
jiva-operator/changelogs/unreleased <- folder
12-github_user_name <- file