From 369fe997869705f7175d2c49f78bf83af73a34cc Mon Sep 17 00:00:00 2001 From: kmova Date: Tue, 10 Nov 2020 19:15:50 +0530 Subject: [PATCH 1/2] fix(build): setup travis push A step to extract the IMAGEID of the ci image was missed causing travis to fail pushing the images. Added the step to extract IMAGEID. Signed-off-by: kmova --- build/push.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/build/push.sh b/build/push.sh index 7d974a9..b8b2b93 100755 --- a/build/push.sh +++ b/build/push.sh @@ -48,6 +48,14 @@ fi # The below steps are required for pushing arch specific images. # This steps will be removed eventually in favour of buildx-push +IMAGEID=$( sudo docker images -q ${DIMAGE}:ci ) +echo "${DIMAGE}:ci -> $IMAGEID" +if [ -z ${IMAGEID} ]; +then + echo "Error: unable to get IMAGEID for ${DIMAGE}:ci"; + exit 1 +fi + # Generate a unique tag based on the commit and tag BUILD_ID=$(git describe --tags --always) From eb2d6f6fcca64985284fce9bd5a3fef5e39b90c1 Mon Sep 17 00:00:00 2001 From: kmova Date: Tue, 10 Nov 2020 19:26:11 +0530 Subject: [PATCH 2/2] fix(build): address lint review comments Signed-off-by: kmova --- build/push.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build/push.sh b/build/push.sh index b8b2b93..471fefa 100755 --- a/build/push.sh +++ b/build/push.sh @@ -48,9 +48,9 @@ fi # The below steps are required for pushing arch specific images. # This steps will be removed eventually in favour of buildx-push -IMAGEID=$( sudo docker images -q ${DIMAGE}:ci ) +IMAGEID=$( sudo docker images -q "${DIMAGE}:ci" ) echo "${DIMAGE}:ci -> $IMAGEID" -if [ -z ${IMAGEID} ]; +if [ -z "${IMAGEID}" ]; then echo "Error: unable to get IMAGEID for ${DIMAGE}:ci"; exit 1