fix(cstor-webhook): fixes pool scaledown bug #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonasingh46
requested review from
prateekpandey14,
mittachaitu and
shubham14bajpai
In case of scaling down a pool by removing a pool spec from the CSPC, webhook server was reporting a out of bounds exception. This commit fixes this bug. Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
sonasingh46
force-pushed
the
scaledown_fix
branch
from
b7a982d to
23500a0
Compare
added 2 commits
July 9, 2020 18:34
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
sonasingh46
pushed a commit
to sonasingh46/cstor-operators
that referenced
this pull request
Jul 9, 2020
…penebs-archive#122) While scaling down a pool by removing a pool spec from the CSPC, there was nil pool list getting initialized due to additional node-selector labels get added in pool list label-selector not matches with existing CSPI labels, causing the webhook failures Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
prateekpandey14
pushed a commit
that referenced
this pull request
Jul 9, 2020
) (#123) While scaling down a pool by removing a pool spec from the CSPC there was nil pool list getting initialized due to additional node-selector labels get added in pool list label-selector, not matches with existing CSPI labels, causing the webhook failures Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of scaling down a pool by removing a pool spec from the CSPC, the webhook server was reporting an out of bounds error. This commit fixes this bug.
Bug Description:
The validation code, in case of scaledown, was trying to list CSPI based on all the labels present on the nodes of the corresponding CSPI. On the other hand, CSPI only has
kubernetes.io/hostnamelabel to it and not all the other node labels. As labels are ANDed for output, we were not getting any items in the CSPI list and hence out of bounds error was caused.Signed-off-by: Ashutosh Kumar ashutosh.kumar@mayadata.io