fix(cstor-webhook): allow scale down of pools when node doesn't exist in cluster #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in cluster Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mittachaitu
requested review from
shubham14bajpai,
prateekpandey14 and
sonasingh46
|
|
…ered simultaneously Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
sonasingh46
approved these changes
Jul 23, 2020
sonasingh46
reviewed
Jul 23, 2020
…he time where node doesn't exist in the cluster Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
| expectedRsp: false, | ||
| getCSPCObj: getCSPCObject, | ||
| }, | ||
| "Positive stripe expansion test when node name chaged": { |
There was a problem hiding this comment.
chaged -> changed ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR does:
In case of scaling down a pool by removing a pool spec
from the CSPC when a pool spec node doesn't exist in
the cluster, the cStor-admission server reported an error
saying no node exists for a given node selector. This PR
fixes this bug.
Bug Description:
performed on the pool it was trying to get common pool specs from old
CSPC spec(CSPC exist in etcd) and new CSPC spec(modified CSPC
which needs to persist in etcd). common pool specs were figured out
by fetching hostName from node resource(node resource will be fetched
from etcd using nodeSelector on pool specs). In node doesn't exist
in the cluster then scaling down operation will be failed.
Issue fixed by this PR : #134
Signed-off-by: mittachaitu sai.chaithanya@mayadata.io