chore(validations): add check for BD tag presence #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilerm
reviewed
Aug 4, 2020
mittachaitu
reviewed
Aug 4, 2020
mittachaitu
reviewed
Aug 4, 2020
added 2 commits
August 6, 2020 10:31
BD can be tagged in order to reserve it to be used later or by other storage engine. If a tag is found in BD then it should not be used by cstor. This commit adds a check for this. If a tag is found in BD and is used in CSPC for cStor pool provisioning then the cStor webhook server will reject the request. Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
pkg/webhook/cspc.go
Outdated
| bd.Name, | ||
| bd.Labels[types.HostNameLabelKey], | ||
| ) | ||
| } |
There was a problem hiding this comment.
We already have a similar check above ^^ line 409-415
There was a problem hiding this comment.
Yes. I think rebasing brought this issue back. Fixed it. Thanks.
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BD can be tagged in order to reserve it to be used later or by other storage
engine. If a tag is found in BD then it should not be used by cstor. This commit
adds a check for this. If a tag is found in BD and is used in CSPC for cStor
pool provisioning then the cStor webhook server will reject the request.
NOTE: This PR https://github.com/openebs/api/pull/62/files needs to be merged first and then a rebase will be required for the current PR.
Signed-off-by: Ashutosh Kumar ashutosh.kumar@mayadata.io