Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(bd-tag): add tutorial for using BD tag feature. #181

Merged
merged 4 commits into from
Sep 28, 2020
Merged

docs(bd-tag): add tutorial for using BD tag feature. #181

merged 4 commits into from
Sep 28, 2020

Conversation

sonasingh46
Copy link
Contributor

Signed-off-by: Ashutosh Kumar ashutosh.kumar@mayadata.io

@sonasingh46 sonasingh46 requested a review from kmova September 17, 2020 09:10
@sonasingh46 sonasingh46 self-assigned this Sep 17, 2020
docs(bd-tag): add tutorial for using BD tag feature.
8d9741d 
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
@sonasingh46 sonasingh46 added documentation Improvements or additions to documentation needs-review labels Sep 18, 2020
akhilerm
akhilerm reviewed Sep 21, 2020
View reviewed changes
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given a few comments @sonasingh46

kmova
kmova approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@kmova kmova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor comment in the intro section to set a milder tone and mostly use positive words in sentences.

Ashutosh Kumar added 2 commits September 22, 2020 14:16
incorporate review comments
90149fe 
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
incorporate review comments
08ea61f 
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
akhilerm
akhilerm approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonasingh46 Once that suggestion is incorporated, LGTM.

incoporate review comments
06d6654 
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
@sonasingh46 sonasingh46 merged commit 5abd4c1 into openebs-archive:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmova kmova kmova approved these changes

@akhilerm akhilerm akhilerm approved these changes

Assignees

@sonasingh46 sonasingh46

Labels
documentation Improvements or additions to documentation needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonasingh46 @akhilerm @kmova