fix(backup, restore): create backup and restore in cstor.openebs.io/v1 group #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1 group Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
sonasingh46
approved these changes
Oct 9, 2020
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates backup and restore in
cstor.openebs.io/v1group if the pool is greater than or equal to 2.2.0.
Note If CStor pool is in ci or dev version then backup and restore
will be created in
cstor.openebs.iogroup.Bug Description: Currently code treats
2.2.0-RC1(pool version)is less than
2.2.0(minimum openebs version to support v1 versionof backup and restore) due to this backup and restore is created in
openebs.iogroup but the backup/restore the controller willunderstand
cstor.openebs.iogroup and will not reconcile for resource.Link: To test versions https://play.golang.org/p/KwHDhCi26Lx comparisons.
Signed-off-by: mittachaitu sai.chaithanya@mayadata.io