fix(cspc): cleanup pending bdcs on cspc deletion #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
shubham14bajpai
requested review from
prateekpandey14,
mittachaitu and
sonasingh46
mittachaitu
reviewed
Dec 1, 2020
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham shubham.bajpai@mayadata.io
What this PR does:
This PR fixes the cleanup issue of BDCs when the CSPIs doesn't get provisioned and CSPC is deleted.
How to replicate the scenario?
Setup the cstor-operator yaml and check whether the BDs are active. Then scale down the ndm-operator deployment, this will prevent the BDCs from getting bound. If we delete the CPSC now the BDCs get the deletion timestamp but the cspc-operator does not remove the finalizer from the pending BDCs.
Tested the below code in the same scenario and the BDCs got cleaned up successfully.