fix(cvc): set the bind address using a go flag in cvc server config #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekpandey14
requested review from
shubham14bajpai
and removed request for
kmova
prateekpandey14
force-pushed
the
refact-entrypoint
branch
2 times, most recently
from
325df2e to
0cb9eca
Compare
prateekpandey14
force-pushed
the
refact-entrypoint
branch
from
0cb9eca to
694b330
Compare
prateekpandey14
force-pushed
the
refact-entrypoint
branch
from
694b330 to
dae61cd
Compare
- Remove the entrypoint.sh script in Dockerfile , used to set the bind address for cvc api server (backup/restore endpoints) reset/overwrite the other flags passed as args to the deployment container. - Updated the cvc operator deployment spec args to include the `-bind` flag to set the server IP using downward API status.podIP Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
prateekpandey14
force-pushed
the
refact-entrypoint
branch
from
dae61cd to
7c524d1
Compare
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prateekpandey14 prateek.pandey@mayadata.io
What this PR does ?
Remove the
entrypoint.shscript in Dockerfile , used to set the bind address for cvc api server (backup/restore endpoints), reset/overwrite the other flags passed as args to the deployment container.Updated the cvc operator deployment spec args to include the
--bindflag to set the server IP using downward APIstatus.podIP