refact(charts): make cleanup pre hook image configurable #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
| @@ -26,10 +26,10 @@ spec: | |||
| - name: kubectl | |||
| {{- /* bitnami maintains an image for all k8s versions */}} | |||
| {{- /* see: https://hub.docker.com/r/bitnami/kubectl */}} | |||
| image: {{ printf "%s/%s:%s.%s" "bitnami" "kubectl" .Capabilities.KubeVersion.Major $kubeMinor }} | |||
| image: "{{ .Values.cleanup.image.registry }}{{ .Values.cleanup.image.repository }}:{{ .Capabilities.KubeVersion.Major }}.{{ $kubeMinor }}" | |||
There was a problem hiding this comment.
Same comment as openebs/charts PR , tag can be different as well.
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
sonasingh46
reviewed
May 26, 2021
| # For example : quay.io/ is a correct value here and quay.io is incorrect | ||
| registry: | ||
| repository: bitnami/kubectl | ||
| tag: |
There was a problem hiding this comment.
Why the tag is empty? Are we going to use latest always?
There was a problem hiding this comment.
The tag is determined in the job template itself using the helm Capabilities to determine the k8s version, which will be same as the tag
sonasingh46
reviewed
May 26, 2021
| @@ -115,6 +115,8 @@ helm install openebs-cstor openebs-cstor/cstor --namespace openebs --create-name | |||
| | admissionServer.resources | object | `{}` | Admission webhook pod resources | | |||
| | admissionServer.securityContext | object | `{}` | Admission webhook security context | | |||
| | admissionServer.tolerations | list | `[]` | Admission webhook tolerations | | |||
| | cleanup.image.registry | string | `nil` | cleanup pre hook image registry | | |||
There was a problem hiding this comment.
Question(n_p) :
nil vs ""
( I see that existing code uses nil )
There was a problem hiding this comment.
The existing values.yaml uses empty fields so I continued with that
prateekpandey14
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham shubham.bajpai@mayadata.io
This PR makes the cleanup pre delete hook job image configurable for air-gap setups