Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cleanup-job): add OR clause to prevent job from failing #346

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

prateekpandey14
Copy link
Contributor

@prateekpandey14 prateekpandey14 commented Jun 18, 2021

Signed-off-by: prateekpandey14 prateek.pandey@mayadata.io

Cleanup job fails if the validatingwebhookconfiguration is deleted beforehand. This stalls helm chart remove. Eventually leads to timeout. Fixed it with a OR clause.

Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
@prateekpandey14 prateekpandey14 requested a review from niladrih June 18, 2021 11:24
@github-actions github-actions bot requested review from kmova and mittachaitu June 18, 2021 11:24
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niladrih niladrih merged commit 89384a7 into openebs-archive:master Jun 18, 2021
@prateekpandey14 prateekpandey14 deleted the fix-cleanjob branch June 18, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants