Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(helm): allow setting different base dir(and others) for cspc and cvc operators #404

Merged
merged 6 commits into from
Dec 7, 2021

Conversation

Ab-hishek
Copy link

@Ab-hishek Ab-hishek commented Nov 19, 2021

Signed-off-by: Abhishek Agarwal abhishek.agarwal@mayadata.io

What this PR does?
Allows setting different hostpath dir paths for OPENEBS_IO_BASE_DIR (and others) in cspc and cvc operator yamls.

Which issue does this PR fix?
issue #396

Signed-off-by: Abhishek Agarwal <abhishek.agarwal@mayadata.io>
Signed-off-by: Abhishek Agarwal <abhishek.agarwal@mayadata.io>
Copy link
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided few comments, PTAL

deploy/helm/charts/README.md Outdated Show resolved Hide resolved
deploy/helm/charts/README.md Outdated Show resolved Hide resolved
deploy/helm/charts/README.md Outdated Show resolved Hide resolved
deploy/helm/charts/templates/cvc-operator.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... one minor comment on naming convention

deploy/helm/charts/README.md Outdated Show resolved Hide resolved
deploy/helm/charts/templates/cspc-operator.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mittachaitu mittachaitu merged commit 8023735 into openebs-archive:develop Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting a different OPENEBS_IO_BASE_DIR (and others) in Helm chart
2 participants