-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(helm): allow setting different base dir(and others) for cspc and cvc operators #404
Conversation
Signed-off-by: Abhishek Agarwal <abhishek.agarwal@mayadata.io>
Signed-off-by: Abhishek Agarwal <abhishek.agarwal@mayadata.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided few comments, PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... one minor comment on naming convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Abhishek Agarwal abhishek.agarwal@mayadata.io
What this PR does?
Allows setting different hostpath dir paths for OPENEBS_IO_BASE_DIR (and others) in cspc and cvc operator yamls.
Which issue does this PR fix?
issue #396