chore(build): make image tags with amd64 for amd64 builds #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
sonasingh46
requested review from
prateekpandey14,
mittachaitu and
shubham14bajpai
mittachaitu
approved these changes
Apr 23, 2020
| @@ -44,9 +44,17 @@ ifeq (${BASE_DOCKER_IMAGE_ARM64}, ) | |||
| endif | |||
|
|
|||
| # Specify the name of the docker repo for amd64 | |||
| CVC_OPERATOR?=cvc-operator | |||
| CSPC_OPERATOR_REPO_NAME=cspc-operator-amd64 | |||
There was a problem hiding this comment.
IMO it will be good if we get CPU architecture from the underlying system
prateekpandey14
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add amd64 in image name for images produced by cstor-operator repo.
Subsequent PRs that will be raised :
NOTES: Corresponding changes to code/operator yaml for the image name change needs to be propagated.
Signed-off-by: Ashutosh Kumar ashutosh.kumar@mayadata.io