chore(log): add cspc information in error event #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -361,7 +361,12 @@ func (c *CVCController) distributeCVRs( | |||
| } | |||
|
|
|||
| if len(usablePoolList.Items) < pendingReplicaCount { | |||
| return errors.New("not enough pools available to create replicas") | |||
| return errors.Errorf( | |||
| "not enough pools available are available of CSPC: %s usable pool count %d to create %d replicas", | |||
There was a problem hiding this comment.
available repeated ?
change to --> "not enough pools are available of provided CSPC: " ?
There was a problem hiding this comment.
How about this?
"not enough pools are available of provided CSPC: %s usable pool count: %d pending replica count: %d"```
There was a problem hiding this comment.
available repeated ? change to --> "not enough pools are available of provided CSPC: " ?
I'm getting this exact error, the only place ive found on github and google with these words is here, i cant find a fix!
Any thoughts ?
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mittachaitu
pushed a commit
to mittachaitu/cstor-operators
that referenced
this pull request
May 12, 2020
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
prateekpandey14
pushed a commit
that referenced
this pull request
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu sai.chaithanya@mayadata.io
This PR adds the CPSC information in the error log. When the user Provision a volume with storage replciaCount > no.of available pools (or) when the user mentioned a typo of CSPC name then event will be shown.