fix(cspi): import pool without cachefile #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
|
go.mod needs to be updated once PR got merged openebs-archive/api#48 |
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
kmova
approved these changes
May 20, 2020
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
sonasingh46
reviewed
May 20, 2020
| echo "cache file is not present in persistent path" | ||
| exit 1 | ||
| fi | ||
|
|
There was a problem hiding this comment.
Awesome job for adding this to ci. ❤️
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mittachaitu
commented
May 20, 2020
| cmdOut, err = zfs.NewPoolImport(). | ||
| WithCachefile(cacheFile). |
There was a problem hiding this comment.
@kmova @sonasingh46 Removed -c cachefile option in the import command for sparse based pool. While building the command directory option will be ignored if cachefile is set.
There was a problem hiding this comment.
As discussed -- let us make the workflow :
- Cache file import
- Then, directory-based import if above fails
For all the pool type -- whether be sparse or disk.
There was a problem hiding this comment.
pushed the changes!! Verifying the same
There was a problem hiding this comment.
Changes look good.
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
sonasingh46
approved these changes
May 20, 2020
shubham14bajpai
approved these changes
May 20, 2020
mittachaitu
pushed a commit
to mittachaitu/cstor-operators
that referenced
this pull request
May 20, 2020
* fix(cspi): fix the import pool bug This commits fixes a bug due to which pool import was failing in case of pool manager pod restarts. Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
prateekpandey14
pushed a commit
that referenced
this pull request
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu sai.chaithanya@mayadata.io
This PR will try to import the pool without the cache file as a last option.
It will import the pool in the following ways:
zpool import -c cachefile=<cache_file> -o cachefile=<cache_file> <pool_name>zpool import -o cachefile=<cache_file> -d <parent_directory_of_sparse_file> <pool_name>zpool import -o cachefile=<cache_file> <pool_name>(By default it will scan /dev directory).Impact to users:
NOTE: