feat(webhook): add cstor-webhook using openebs/api changes #8
Conversation
shubham14bajpai
changed the title
| } | ||
|
|
||
| // GetClusterConfig return the config for k8s. | ||
| func getClusterConfig(kubeconfig string) (*rest.Config, error) { |
There was a problem hiding this comment.
this func is getting used every where let's have in a single place and use it instead , we can do this change later in upcoming PRs.
Better to use below func helpful in case of outofcluster runs as binary
// GetClusterConfig return the config for k8s.
func getClusterConfig(kubeconfig string) (*rest.Config, error) {
if kubeconfig != "" {
return clientcmd.BuildConfigFromFlags("", kubeconfig)
}
return rest.InClusterConfig()
}There was a problem hiding this comment.
Above change can be done later, we are using above getConfig func in case of other controller like cvc-controller, cspc-controller .
| cstor.PoolRaidz: 3, | ||
| cstor.PoolRaidz2: 6, | ||
| } | ||
| ) |
There was a problem hiding this comment.
ToDo: Fix the min validation in next PR. As for raidz1 and raidz2 the min is 2^n+1 and 2^n+2 respectively,
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
| // transformation function lists to upgrade webhook resources | ||
| transformSecret = []transformSecretFunc{} | ||
| transformSvc = []transformSvcFunc{} | ||
| transformConfig = []transformConfigFunc{} |
There was a problem hiding this comment.
Should we need to include that upgrade related functions? Or the user will be always in the latest version so not required to have them is that the idea?
There was a problem hiding this comment.
This is the framework for future upgrades like adding and removing rules. This code will not affect the current state.
| ) error { | ||
|
|
||
| // Fetch our namespace | ||
| openebsNamespace, err := getOpenebsNamespace() |
There was a problem hiding this comment.
Maybe in the next PR's, we can set one global variable for the namespace and we will reuse it everywhere it's not good to fetch the value from env.
There was a problem hiding this comment.
Will take this in upcoming PR.
| blockDeviceMap := map[string]bool{} | ||
| addedBlockDevices := map[string]bool{} | ||
| for _, poolSpec := range cspc.Spec.Pools { | ||
| for _, raidGroup := range poolSpec.DataRaidGroups { |
There was a problem hiding this comment.
Is there a TODO task for WriteCacheRaidGroups?
| } | ||
| if _, ok := SupportedPRaidType[cstor.PoolType(poolConfig.DataRaidGroupType)]; !ok { | ||
| return false, fmt.Sprintf("unsupported raid type '%s' specified", poolConfig.DataRaidGroupType) | ||
| } |
There was a problem hiding this comment.
This check is also required
if len(poolValidator.poolSpec.WriteCacheRaidGroups) != 0 {
if _, ok := SupportedPRaidType[cstor.PoolType(PoolConfig.WriteCacheRaidType)] == "" ; !ok {
return false, msg
}There was a problem hiding this comment.
This is a new schema validation will take all new schema validation in separate PR.
| } | ||
|
|
||
| if rgType != string(cstor.PoolStriped) { | ||
| if len(raidGroup.BlockDevices) != SupportedPRaidType[cstor.PoolType(rgType)] { |
There was a problem hiding this comment.
TODO: Update check in next PR's
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham shubham.bajpai@mayadata.io
This PR adds webhook server code to validate cstor related create, update and delete requests.