Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(restore-controller): add suport for restore controller #87

Merged

Conversation

sonasingh46
Copy link
Contributor

@sonasingh46 sonasingh46 commented May 31, 2020

This PR adds the restore controller in the pool manager.
Fixes #76
ToDo: Add Unit Tests

Signed-off-by: Ashutosh Kumar ashutosh.kumar@mayadata.io

Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Copy link
Contributor

@mynktl mynktl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

pkg/volumereplica/volumereplica.go Outdated Show resolved Hide resolved
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Ashutosh Kumar added 2 commits June 2, 2020 17:43
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Copy link
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Copy link
Contributor

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prateekpandey14 prateekpandey14 merged commit 117c373 into openebs-archive:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add restore controller to pool manager in accordance to v1 api changes.
4 participants