Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cvc): add cvc-controller fake client mock tests #93

Merged
merged 1 commit into from
Jul 8, 2020
Merged

chore(cvc): add cvc-controller fake client mock tests #93

merged 1 commit into from
Jul 8, 2020

Conversation

prateekpandey14
Copy link
Contributor

Signed-off-by: prateekpandey14 prateek.pandey@mayadata.io

@prateekpandey14 prateekpandey14 linked an issue Jun 11, 2020 that may be closed by this pull request
CVC controller mock and fake testing #80
Closed
@prateekpandey14
chore(cvc): add cvc-controller fake client mock tests
6a60f84 
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
@prateekpandey14 prateekpandey14 self-assigned this Jul 6, 2020
@mittachaitu mittachaitu self-requested a review July 7, 2020 05:06
mittachaitu
mittachaitu approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

pkg/controllers/cstorvolumeconfig/controller_test.go Show resolved Hide resolved
@prateekpandey14 prateekpandey14 merged commit 716d4a2 into openebs-archive:master Jul 8, 2020
@prateekpandey14 prateekpandey14 deleted the add-cvc-tests branch July 8, 2020 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mittachaitu mittachaitu mittachaitu approved these changes

Assignees

@prateekpandey14 prateekpandey14

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVC controller mock and fake testing
2 participants
@prateekpandey14 @mittachaitu