feat(schd): returning list of preferred nodes for scheduling #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
changed the title
Scheduler should return list of preferred nodes for scheduling. It is up to the user of this libary which can pick first node in the preferred list or can try on all the nodes in the order returned by the scheduler. This can solve the issue where csi controller is not able to create the volume on first node, it can pick the next one in the list. Signed-off-by: Pawan <pawan@mayadata.io>
7 tasks
Signed-off-by: Pawan <pawan@mayadata.io>
kmova
reviewed
Jan 30, 2021
| @@ -56,43 +62,68 @@ func getNodeList(topo *csi.TopologyRequirement) ([]string, error) { | |||
|
|
|||
| // runScheduler goes through the node mapping | |||
| // in the topology and picks the node which is less weighted | |||
| func runScheduler(nodelist []string, nmap map[string]int64) string { | |||
| var selected string | |||
| func runScheduler(nodelist []string, nmap map[string]int64) []string { | |||
There was a problem hiding this comment.
n_: the comments needs to change to reflect the change in the logic.
kmova
reviewed
Jan 30, 2021
| topo := req.AccessibilityRequirements | ||
| if topo == nil || | ||
| len(topo.Preferred) == 0 { | ||
| func Scheduler(req *csi.CreateVolumeRequest, nmap map[string]int64) []string { |
There was a problem hiding this comment.
q_: is it required to maintain backward compatibility for this API so that any of the CSI drivers using this method can still work, after this is merged and if they are using the latest code from this repo (without changing their code.
There was a problem hiding this comment.
it will work even after the merge because of the gomod.
Signed-off-by: Pawan <pawan@mayadata.io>
kmova
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduler should return list of preferred nodes for scheduling.
It is up to the user of this libary which can pick first node in
the preferred list or can try on all the nodes in the order returned
by the scheduler.
This can solve the issue where csi controller is not able to create
the volume on first node, it can pick the next one in the list.
Signed-off-by: Pawan pawan@mayadata.io