fix(overprovisioning): fix overprovisioning bug in case of clone volume #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug that was not allowing the clone volumes to get created if overprovisioning was disabled. Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
sonasingh46
requested review from
prateekpandey14,
mittachaitu and
nsathyaseelan
AmitKumarDas
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug that was not allowing the clone volumes to
get created if overprovisioning was disabled.
Details :
In the case of clone volumes, the capacity of CSP was not being passed which caused the overprovisioning policy to error out due to empty capacity.
Now clone volume will be created on the specific pools only where the source volume exists.
To fix this, an entire map of CSP capacity vs uid is passed via runtask and the capacity for the specific CSP where clone volume needs to come is picked from the map to decide on overprovisioning requirements.
Signed-off-by: Ashutosh Kumar ashutosh.kumar@mayadata.io