-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pendingsnapshots): add pending snapshots on CVR by talking to peer replicas #1641
Merged
vishnuitta
merged 4 commits into
openebs-archive:master
from
mittachaitu:add_pending_snapshots
Apr 1, 2020
Merged
feat(pendingsnapshots): add pending snapshots on CVR by talking to peer replicas #1641
vishnuitta
merged 4 commits into
openebs-archive:master
from
mittachaitu:add_pending_snapshots
Apr 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er replicas Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mynktl
reviewed
Mar 31, 2020
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
vishnuitta
reviewed
Mar 31, 2020
vishnuitta
reviewed
Mar 31, 2020
vishnuitta
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good..
asked for a fn name change, and few logs
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
vishnuitta
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good
mynktl
approved these changes
Apr 1, 2020
mittachaitu
added
pr/ready-to-merge
PR has enough approvals and ready to merge
and removed
pr/hold-merge
Hold on the merge to complete few activities.
labels
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the pending snapshots under CVR status.pendingsnapshots only if CVR underwent
Rebuilding
. This PR is continuation of PR #1639.How Does It Gets Pending Snapshots:
The replica which is undergoing rebuilding will get the list of pending snapshots from other peer CVR's Snapshot information.
Sample YAML output when Rebuilding is in Progress:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes openebs/openebs#2936 (Part of the issue will be fixed).Special notes for your reviewer:
Checklist:
documentation
tagbreaking-changes
tagrequires-upgrade
tag