Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jiva): add tolerations to jiva cleanup jobs #1667

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Apr 11, 2020

Signed-off-by: shubham shubham.bajpai@mayadata.io

What this PR does / why we need it:
This PR fixes the issue: if the jiva volume is deployed with custom replica tolerations while deleting the cleanup jobs are not able to schedule on the tainted nodes.
Adding the replica toleration to jobs fixes the issue.

Storageclass used:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: jiva-2r
  annotations:
    openebs.io/cas-type: jiva
    cas.openebs.io/config: |
      - name: ReplicaCount
        value: "2"
      - name: ReplicaTolerations
        value: |
          t1:
            key: "nodeType"
            operator: "Equal"
            value: "storage"
            effect: "NoSchedule"

Tolerations set on replica deployment:

tolerations:
  - effect: NoExecute
    key: node.alpha.kubernetes.io/notReady
    operator: Exists
  - effect: NoExecute
    key: node.cloudprovider.kubernetes.io/uninitialized
    operator: Exists
  - effect: NoExecute
    key: node.alpha.kubernetes.io/unreachable
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/out-of-disk
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/memory-pressure
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/disk-pressure
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/network-unavailable
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/unschedulable
    operator: Exists
  - effect: NoSchedule
    key: nodeType
    operator: Equal
    value: storage

Tolerations set on cleanup job:

tolerations:
  - effect: NoSchedule
    key: nodeType
    operator: Equal
    value: storage
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 300
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 300

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist:

  • Fixes #
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
@kmova kmova merged commit 99049c6 into openebs-archive:master Apr 11, 2020
@kmova kmova added the pr/release-note PR should be included in release notes label Apr 11, 2020
@shubham14bajpai shubham14bajpai deleted the jiva-clean branch October 12, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/release-note PR should be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants